Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kvfrac leakage #325

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Kvfrac leakage #325

merged 5 commits into from
Jan 12, 2024

Conversation

verseve
Copy link
Contributor

@verseve verseve commented Jan 11, 2024

Issue addressed

Issue was not reported.

Explanation

Include kvfrac in the computation of vertical saturated hydraulic conductivity at the bottom of the soil layer, so it is consistent with the unsaturated vertical flow computation.

Checklist

  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

Include multiplication factor `kvfrac` in the computation of vertical saturated hydraulic conductivity at the bottom of the soil, so it is consistent with unsaturated vertical flow computation.
@verseve verseve self-assigned this Jan 11, 2024
@verseve verseve requested a review from JoostBuitink January 11, 2024 07:33
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, good to be consistent indeed ;)

As we discussed, in the future, it might be nice to have recharge presented in a more "user-friendly" way (m/dt or m3/d). If you agree, I can make an issue so we wont forget.

@verseve
Copy link
Contributor Author

verseve commented Jan 12, 2024

As we discussed, in the future, it might be nice to have recharge presented in a more "user-friendly" way (m/dt or m3/d). If you agree, I can make an issue so we wont forget.

Yes, I agree, would be good to make an issue for this!

@verseve verseve merged commit f793a2e into master Jan 12, 2024
12 checks passed
@JoostBuitink JoostBuitink deleted the kvfrac_leakage branch January 12, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants